[PATCH] D111879: [Support] Add a new path style for Windows with forward slashes

[Duncan P. N. Exon Smith via Phabricator via llvm-commits]

dexonsmith added inline comments.


================
Comment at: llvm/unittests/Support/Path.cpp:89-92
   // Check is_style_native().
   EXPECT_TRUE(is_style_native(Style::native));
   EXPECT_EQ(is_style_posix(Style::native), is_style_native(Style::posix));
   EXPECT_EQ(is_style_windows(Style::native), is_style_native(Style::windows));
----------------
FYI, I just caught myself wondering what `is_style_native()` *should* return for `Style::windows_slash` and `Style::windows_backslash` when running on Windows. In practice (at least right now) it will return true for both. But I'm not sure if most people looking at a call to `is_style_native()` could guess correctly, and I could see a justifications for being more fine-grained.

So, I removed it in 8077a19f66b50573a043ef1c405e2149e0c69cb7.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D111879/new/

https://reviews.llvm.org/D111879