[PATCH] D111879: [Support] Add a new path style for Windows with forward slashes
Duncan P. N. Exon Smith via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Oct 29 12:38:48 PDT 2021
dexonsmith added inline comments.
================
Comment at: llvm/unittests/Support/Path.cpp:72
TEST(is_style_Style, Works) {
using namespace llvm::sys::path;
----------------
Also, might be good to add `windows_slash` and `windows_backslash` to the tests here.
================
Comment at: llvm/unittests/Support/Path.cpp:1456
#if defined(_WIN32)
SmallString<64> PathHome;
----------------
Mostly unrelated to this patch, but I wonder if adding llvm::sys::fs::is_windows() (or is_system_windows or is_filesystem_windows or llvm::sys::is_windows or ...) and _posix() would lead to good cleanups.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D111879/new/
https://reviews.llvm.org/D111879
More information about the llvm-commits
mailing list