[PATCH] D112849: [llvm] Disable xar on macOS 12.0 and later

[Petr Hosek via Phabricator via llvm-commits]

phosek added inline comments.


================
Comment at: llvm/cmake/config-ix.cmake:216
 if(LLVM_HAVE_LIBXAR)
-  set(XAR_LIB xar)
+  message(STATUS "The xar file format has been deprecated: LLVM_HAVE_LIBXAR has might be removed in the future.")
+  # The xar file format has been deprecated since macOS 12.0.
----------------



================
Comment at: llvm/cmake/config-ix.cmake:218
+  if (CMAKE_OSX_DEPLOYMENT_TARGET VERSION_GREATER_EQUAL 12)
+    set(LLVM_HAVE_LIBXAR 0)
+  else()
----------------
JDevlieghere wrote:
> phosek wrote:
> > Could we also print a warning that this option is deprecated and might be removed in future versions?
> Is this what you had in mind? I didn't use an actual warning because the variable is set based on whether the library exists and therefore isn't really actionable. This seems like a nice middle ground. 
Yes, thanks.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D112849/new/

https://reviews.llvm.org/D112849