[PATCH] D112849: [llvm] Disable xar on macOS 12.0 and later

Fri Oct 29 15:11:41 PDT 2021

JDevlieghere added inline comments.

================
Comment at: llvm/cmake/config-ix.cmake:218
+  if (CMAKE_OSX_DEPLOYMENT_TARGET VERSION_GREATER_EQUAL 12)
+    set(LLVM_HAVE_LIBXAR 0)
+  else()
----------------
phosek wrote:
> Could we also print a warning that this option is deprecated and might be removed in future versions?
Is this what you had in mind? I didn't use an actual warning because the variable is set based on whether the library exists and therefore isn't really actionable. This seems like a nice middle ground. 

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D112849/new/

https://reviews.llvm.org/D112849