[PATCH] D112748: [release] Use the Bootstrapping build for building LLVM releases

Tom Stellard via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Oct 29 12:35:44 PDT 2021


tstellar added a comment.

In D112748#3097480 <https://reviews.llvm.org/D112748#3097480>, @ldionne wrote:

> In D112748#3094717 <https://reviews.llvm.org/D112748#3094717>, @tstellar wrote:
>
>> In D112748#3094557 <https://reviews.llvm.org/D112748#3094557>, @ldionne wrote:
>>
>>> Also, @tsellar, do you want the LLVM releases to be built using the just-built Clang, or the system compiler? IMO it makes sense to use the bootstrapping build, but if we want to build the Phase 1 runtimes using the system compiler, we could use two CMake invocations, one rooted at `<monorepo>/llvm` and one rooted at `<monorepo>/runtimes`. This patch assumes that we want to bootstrap Clang and build the runtimes with it at each phase.
>>
>> Using the bootstrap build seems fine with me.  Is the phase1 runtime build used in phase2 or phase3 or is it just discarded?
>
> In the current setup, it would be discarded. I *think* both alternatives are viable -- perhaps it would be better to build the Phase2/3 Clang against the previous phase's runtime libraries, but I think it would be fine to do this as a follow-up since right now we never use the previous phase's runtimes IIUC. Is that correct?

Yes, we can make other changes here in a a follow up change if we want.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D112748/new/

https://reviews.llvm.org/D112748



More information about the llvm-commits mailing list