[PATCH] D112748: [release] Use the Bootstrapping build for building LLVM releases

[Louis Dionne via Phabricator via llvm-commits]

ldionne added a comment.

In D112748#3094717 <https://reviews.llvm.org/D112748#3094717>, @tstellar wrote:

> In D112748#3094557 <https://reviews.llvm.org/D112748#3094557>, @ldionne wrote:
>
>> Also, @tsellar, do you want the LLVM releases to be built using the just-built Clang, or the system compiler? IMO it makes sense to use the bootstrapping build, but if we want to build the Phase 1 runtimes using the system compiler, we could use two CMake invocations, one rooted at `<monorepo>/llvm` and one rooted at `<monorepo>/runtimes`. This patch assumes that we want to bootstrap Clang and build the runtimes with it at each phase.
>
> Using the bootstrap build seems fine with me.  Is the phase1 runtime build used in phase2 or phase3 or is it just discarded?

In the current setup, it would be discarded. I *think* both alternatives are viable -- perhaps it would be better to build the Phase2/3 Clang against the previous phase's runtime libraries, but I think it would be fine to do this as a follow-up since right now we never use the previous phase's runtimes IIUC. Is that correct?

Note that for the above to be correct, we have to fix the fact that the runtimes aren't built at all with this patch as-is, see my question to @phosek above. We won't move forward with this change until it has been addressed, of course.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D112748/new/

https://reviews.llvm.org/D112748