[PATCH] D112595: [IRSymTab] Mark __stack_chk_guard used

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Oct 27 14:35:03 PDT 2021


MaskRay added a comment.

LG



================
Comment at: llvm/lib/Object/IRSymtab.cpp:51
+    // TODO: Are there similar such variables?
+    "__stack_chk_guard"
 };
----------------
Add a comma so that a follow-up doesn't need to patch this line.


================
Comment at: llvm/test/ThinLTO/X86/builtin-nostrip.ll:44
 ; CHECK-NM-NOT: bar
+; CHECK-NM-DAG: D __stack_chk_guard
 ; CHECK-NM-DAG: T __stack_chk_fail
----------------
llvm-nm sorts the symbols alphabetically by default. No need for `-DAG`


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D112595/new/

https://reviews.llvm.org/D112595



More information about the llvm-commits mailing list