[PATCH] D112595: [IRSymTab] Mark __stack_chk_guard used

Wed Oct 27 08:36:53 PDT 2021

tejohnson added a comment.

In D112595#3089374 <https://reviews.llvm.org/D112595#3089374>, @ychen wrote:

> In D112595#3089372 <https://reviews.llvm.org/D112595#3089372>, @MaskRay wrote:
>
>> Can `__stack_chk_fail` be removed from `llvm/lib/Transforms/IPO/Internalize.cpp`?
>
> It would not be removed there. `Internalize.cpp` preserves both `__stack_chk_fail` and the guard symbol.

I'm confused after reading the referenced bug, which is about doing something to be able to remove this value's hardcoding from Internalize.cpp. Does the newly added test case fail without the IRSymtab change in this patch? There are a couple other symbols handled specially in Internalize.cpp (__stack_chk_fail, and __ssp_canary_word for AIX), should the all be handled uniformly?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D112595/new/

https://reviews.llvm.org/D112595