[PATCH] D111875: [Support] [Windows] Manually clean up temp files on network shares

[Martin Storsjö via Phabricator via llvm-commits]

mstorsjo added a comment.

In D111875#3091485 <https://reviews.llvm.org/D111875#3091485>, @andrewevstyukhin wrote:

> In D112376#3089850 <https://reviews.llvm.org/D112376#3089850>, @mstorsjo wrote:
>
>> Hmm, I think this would work with D111875 <https://reviews.llvm.org/D111875> then, if I’d update it to remove the check for the specific error code on the return from `setDeleteDisposition`?
>
> It'll be great! Current diff still doesn't work with the RAM-disk https://sourceforge.net/projects/imdisk-toolkit/:
> `if (EC == errc::not_supported) {` misses `errc::function_not_supported`.
>
> I've successfully tested locally this approach: `if (EC == errc::not_supported || EC == errc::function_not_supported) {`

Thanks for testing! Maybe it'd be best and safest to remove that if statement altogether - as long as we successfully opened the file, we don't need to bother about the various reasons why `setDeleteDisposition` can fail, as we can just skip that and go on with the manual deletion.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D111875/new/

https://reviews.llvm.org/D111875