[PATCH] D111875: [Support] [Windows] Manually clean up temp files on network shares

Andrew Evstyukhin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Oct 27 13:58:15 PDT 2021


andrewevstyukhin added a comment.

In D112376#3089850 <https://reviews.llvm.org/D112376#3089850>, @mstorsjo wrote:

> Hmm, I think this would work with D111875 <https://reviews.llvm.org/D111875> then, if I’d update it to remove the check for the specific error code on the return from `setDeleteDisposition`?

It'll be great! Current diff still doesn't work with the RAM-disk https://sourceforge.net/projects/imdisk-toolkit/:
`if (EC == errc::not_supported) {` misses `errc::function_not_supported`.

I've successfully tested locally this approach: `if (EC == errc::not_supported || EC == errc::function_not_supported) {`


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D111875/new/

https://reviews.llvm.org/D111875



More information about the llvm-commits mailing list