[PATCH] D107886: [PowerPC] Support huge frame size for PPC64

[Kai Luo via Phabricator via llvm-commits]

lkail marked 2 inline comments as done.
lkail added inline comments.


================
Comment at: llvm/lib/Target/PowerPC/PPCRegisterInfo.cpp:1495
+      assert(is64Bit && "Huge stack is only supported on PPC64");
+      BuildMI(MBB, II, dl, TII.get(PPC::LIS8) , SReg)
+        .addImm(Offset >> 48);
----------------
nemanjai wrote:
> Why is this repeated here rather than calling `materializeImmPostRA()` as you do in other places?
This is subtle, I've checked the commit https://github.com/llvm/llvm-project/commit/d8a423cd71bb2a9b7666fd58fc82db16b4666d1d of the code above. It intends to keep variables for Registers SSA-like but `materializeImmPostRA` violates this rule.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D107886/new/

https://reviews.llvm.org/D107886