[PATCH] D112376: [Support] [Windows] Use the regular RemoveFileOnSignal() mechanism on Windows too

[Reid Kleckner via Phabricator via llvm-commits]

rnk added a comment.

In D112376#3088384 <https://reviews.llvm.org/D112376#3088384>, @akhuang wrote:

> I think on Windows the RemoveFileOnSignal path doesn't always work when the process is killed, which causes temp files to be left sometimes (see https://reviews.llvm.org/D102736)

Yeah, at least in our usage, we found RemoveFileOnSignal was unreliable. The fancy delete disposition feature seemed like exactly what we wanted, it's just a shame that it only seems to work on local NTFS volumes.

I was going to try to come up with one last alternative, something like splitting OF_Delete into OF_DeleteOnClose and OF_Delete. One gives you the ability to delete the file, and the other is the old delete-on-close semantic. Does that work? Sorry for the delay, apologies if I missed something while skimming...


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D112376/new/

https://reviews.llvm.org/D112376