[PATCH] D112376: [Support] [Windows] Use the regular RemoveFileOnSignal() mechanism on Windows too

Martin Storsjö via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Oct 26 12:30:22 PDT 2021


mstorsjo added a comment.

In D112376#3088384 <https://reviews.llvm.org/D112376#3088384>, @akhuang wrote:

> I think on Windows the RemoveFileOnSignal path doesn't always work when the process is killed, which causes temp files to be left sometimes (see https://reviews.llvm.org/D102736)

Oh, thanks. That's indeed a good reason for keeping the existing approach, although it seems to become a giant pile of hacks/workarounds... I'll see what I can do on the other patch again, then.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D112376/new/

https://reviews.llvm.org/D112376



More information about the llvm-commits mailing list