[PATCH] D112451: implemented R_AARCH64_ADR_PREL_PG_HI21, R_AARCH64_ADR_PREL_PG_HI21_NC, R_AARCH64_ADD_ABS_LO12_NC

Mon Oct 25 12:11:31 PDT 2021

sgraenitz added inline comments.

================
Comment at: llvm/test/ExecutionEngine/JITLink/AArch64/ELF_aarch64_test1.s:3
+# RUN: llvm-mc -triple=aarch64 -filetype=obj -o %t %s
+# RUN: llvm-jitlink -debug-only=jitlink -noexec %t 2>&1 | FileCheck %s
+	.text
----------------
sgraenitz wrote:
> My initial recommendation to use FileCheck was not good. JITLink tests actually use `jitlink-check`, which accepts some limited expressions to aid validation. I have to look up the details again as well.
> 
> Maybe this example can give you some idea how it works: https://reviews.llvm.org/D90331#change-XdnNV6F7d9o7
@lhames Is there documentation for jitlink-check somewhere? I remember that it's using `RuntimeDyldChecker` under the hood and that it's a little complicated..

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D112451/new/

https://reviews.llvm.org/D112451