[PATCH] D112452: [PPC][LLVM] Inclusive terms: remove references to sanity check in lib/Target/PowerPC

Zarko Todorovski via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Oct 25 07:13:26 PDT 2021


ZarkoCA created this revision.
ZarkoCA added reviewers: nemanjai, quinnp, lei.
Herald added subscribers: shchenz, kbarton, hiraditya.
ZarkoCA requested review of this revision.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.

Removed references to `sanity check` in `PPCBranchCoalescing.cpp` code comments.
No word substitution made in this case, as the comments and code following illustrated are
sufficient IMO.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D112452

Files:
  llvm/lib/Target/PowerPC/PPCBranchCoalescing.cpp


Index: llvm/lib/Target/PowerPC/PPCBranchCoalescing.cpp
===================================================================
--- llvm/lib/Target/PowerPC/PPCBranchCoalescing.cpp
+++ llvm/lib/Target/PowerPC/PPCBranchCoalescing.cpp
@@ -291,7 +291,7 @@
     return false;
   }
 
-  // Sanity check - the block must be able to fall through
+  // The block must be able to fall through.
   assert(Cand.BranchBlock->canFallThrough() &&
          "Expecting the block to fall through!");
 
@@ -751,9 +751,8 @@
       if (!canCoalesceBranch(Cand2))
         break;
 
-      // Sanity check
       // The branch-taken block of the second candidate should post-dominate the
-      // first candidate
+      // first candidate.
       assert(MPDT->dominates(Cand2.BranchTargetBlock, Cand1.BranchBlock) &&
              "Branch-taken block should post-dominate first candidate");
 


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D112452.381982.patch
Type: text/x-patch
Size: 867 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20211025/90c1516f/attachment.bin>


More information about the llvm-commits mailing list