[PATCH] D110865: X86InstrInfo: Optimize more combinations of SUB+CMP

Matthias Braun via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Oct 24 17:03:02 PDT 2021


MatzeB marked 2 inline comments as done.
MatzeB added inline comments.


================
Comment at: llvm/lib/Target/X86/X86InstrInfo.h:637
+  /// This function can be extended later on.
+  /// SrcReg, SrcRegs: register operands for FlagI.
+  /// ImmValue: immediate for FlagI if it takes an immediate.
----------------
RKSimon wrote:
> SrcRegs -> SrcReg2 ?
I previously just moved this text from the .cpp file...

I'll rewrite the whole comment from scratch.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110865/new/

https://reviews.llvm.org/D110865



More information about the llvm-commits mailing list