[PATCH] D112371: [lld-macho] Don't merge cstrings across different sections

[Jez Ng via Phabricator via llvm-commits]

int3 added a comment.

I don't know. I'm trying to debug a "unrecognized selector" crash in one of my programs right now, and so I've been looking at discrepancies between the ObjC-related data in LLD vs ld64's outputs. I saw that the `__objc_methname` and other similar strings in ld64's output remained in their original sections, whereas we were merging them all into `__cstring`. I don't think this diff fixes the original crash, but I figured having fewer discrepancies between the two binaries would be a good thing regardless.

However, if you would prefer we not land this until there's a demonstrated need, I'm with that too.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D112371/new/

https://reviews.llvm.org/D112371