[PATCH] D108750: [PowerPC] common chains to reuse offsets to reduce register pressure

[ChenZheng via Phabricator via llvm-commits]

shchenz added inline comments.


================
Comment at: llvm/lib/Target/PowerPC/PPCLoopInstrFormPrep.cpp:498
+
+  for (const auto &BB : L->blocks())
+    for (auto &J : *BB) {
----------------
jsji wrote:
> shchenz wrote:
> > jsji wrote:
> > > We already collected both Dform and DQform buckets before, can we reuse some info to do early exit?
> > Good idea. We can share the info among all forms. I split this into a new patch D112196.
> D112196 looks good. But I think we can still do more for this? eg: If both Dform and DQform buckets are empty, then there is no point trying to run this commoning either?
Not exactly, ds/dq forms require the diff between elements must be constants, but we can prepare for non-constant diffs for chain commoning.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D108750/new/

https://reviews.llvm.org/D108750