[PATCH] D112198: [MLIR][OpenMP] Fixed the missing inclusive clause in omp.wsloop

[Shraiysh via Phabricator via llvm-commits]

shraiysh marked 3 inline comments as done.
shraiysh added inline comments.


================
Comment at: mlir/lib/Dialect/OpenMP/IR/OpenMPDialect.cpp:886
       reductionClause, collapseClause,     orderClause,       orderedClause,
-      nowaitClause,    scheduleClause};
+      nowaitClause,    scheduleClause,     inclusiveClause};
   SmallVector<int> segments{numIVs, numIVs, numIVs};
----------------
kiranchandramohan wrote:
> clementval wrote:
> > shraiysh wrote:
> > > clementval wrote:
> > > > That would be nice to be able to generate this kind of list from the OMP.td file so this kind of problem would not occur. 
> > > Hmm, that is true. I will try to look into this sometime later.
> > Sure it's not smth urgent right now but good to keep it on the omp todo list. 
> inclusive is not a clause from the OpenMP standard. It is a property of the DO loop associated with the OpenMP worksharing loop. Just like we do not have `upper_bound`, `lower_bound` and `step` as clauses here, I think we should not list inclusive also as a clause and deal with it like `upper_bound`, `lower_bound` and `step`.
> 
> BTW, the test for inclusive was in generic syntax that is why we did not catch missing this. As @peixin says it will be good to go through all the clauses and see whether there is a test for the pretty syntax.
Done!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D112198/new/

https://reviews.llvm.org/D112198