[PATCH] D112198: [MLIR][OpenMP] Fixed the missing inclusive clause in omp.wsloop

Shraiysh via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Oct 21 03:34:16 PDT 2021


shraiysh updated this revision to Diff 381196.
shraiysh added a comment.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.

Thanks @kiranchandramohan @peixin and @clementval for the review.

Moved inclusive out of clauses. Added tests for other clauses. Please let me know if you see any missing test-cases. I have not added failing test cases for the clauses which are allowed by the standard but not supported by the operations right now.
Handled order clause, the constraint was not accepting the `concurrent` value and the default value could not be provided by the user. So, essentially it was absent. Added test for the same.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D112198/new/

https://reviews.llvm.org/D112198

Files:
  llvm/include/llvm/Frontend/OpenMP/OMP.td
  mlir/lib/Dialect/OpenMP/IR/OpenMPDialect.cpp
  mlir/test/Dialect/OpenMP/invalid.mlir
  mlir/test/Dialect/OpenMP/ops.mlir

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D112198.381196.patch
Type: text/x-patch
Size: 10009 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20211021/682c2d02/attachment.bin>


More information about the llvm-commits mailing list