[PATCH] D110464: [lld-macho][nfc] Added some notes on deliberate differences btw LLD vs LD64

Vy Nguyen via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Oct 20 18:03:59 PDT 2021


oontvoo marked 7 inline comments as done.
oontvoo added inline comments.


================
Comment at: lld/MachO/notes.txt:15
+
+  - Handling of personality symbols
+
----------------
thevinster wrote:
> Are you planning to continue this section here?
I was undecided - (we're imitating Ld64 now but may revert that in a very near future ... let's leave this out for now)


================
Comment at: lld/MachO/notes.txt:18
+
+// FIXME: There's something to say about section alignment. I forgot...
----------------
thevinster wrote:
> If we're planning to check this in, it might seem best to leave FIXME's out of notes. It's not code and you could always add this in when you remember. :)
I was hoping someone would clarify this cos I'd forgotten what the subtlety was ... :)



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110464/new/

https://reviews.llvm.org/D110464



More information about the llvm-commits mailing list