[PATCH] D110464: [lld-macho][nfc] Added some notes on deliberate differences btw LLD vs LD64
Jez Ng via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Oct 18 12:04:57 PDT 2021
int3 requested changes to this revision.
int3 added a comment.
This revision now requires changes to proceed.
We could just put in the paragraph about `-ObjC` for now. The symbol behavior is something that should definitely be included once we can make it more precise.
Can we make this a `.rst` file? Ultimately we should put this under `lld/docs` so we have nice web-readable documentation, and all the files there are `.rst`. But while we're drafting it, it can stay under `MachO/`.
================
Comment at: lld/MachO/notes.txt:5
+ - General resolution rule:
+ + LD64: the "winning" symbols are chosen based on several criteria.
+ + LLD: metadata from symbols with the same are merged, and the content of
----------------
thevinster wrote:
> It might seem more useful if we clarify what those criteria are?
it's partially alphabetical IIRC. but yeah, we should be more precise here
================
Comment at: lld/MachO/notes.txt:6-7
+ + LD64: the "winning" symbols are chosen based on several criteria.
+ + LLD: metadata from symbols with the same are merged, and the content of
+ the first symbol in the symbol table with that name is kept.
+
----------------
thevinster wrote:
>
"metadata" and "content" are kind of vague terms here. I suppose `content` is `Defined::value`...
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D110464/new/
https://reviews.llvm.org/D110464
More information about the llvm-commits
mailing list