[PATCH] D111875: [Support] [Windows] Manually clean up temp files on network shares

Wed Oct 20 13:24:19 PDT 2021

mstorsjo added a comment.

In D111875#3076260 <https://reviews.llvm.org/D111875#3076260>, @akhuang wrote:

> This also appears to fix another llvm bug filed on a windows ram drive issue (https://bugs.llvm.org/show_bug.cgi?id=52080), which is cool.

Oh, nice!

================
Comment at: llvm/lib/Support/Windows/Path.inc:417

   // Check if the file is on a network (non-local) drive. If so, don't
   // continue when DeleteFile is true, since it prevents opening the file for
----------------
akhuang wrote:
> Should we change this comment (or maybe just remove this section?), since it seems like this patch tries to avoid this path?
Good catch! Yes we should change that. I'll revise the patch.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D111875/new/

https://reviews.llvm.org/D111875