[PATCH] D111875: [Support] [Windows] Manually clean up temp files on network shares

Wed Oct 20 13:12:59 PDT 2021

akhuang added a comment.

This also appears to fix another llvm bug filed on a windows ram drive issue (https://bugs.llvm.org/show_bug.cgi?id=52080), which is cool.

================
Comment at: llvm/lib/Support/Windows/Path.inc:417

   // Check if the file is on a network (non-local) drive. If so, don't
   // continue when DeleteFile is true, since it prevents opening the file for
----------------
Should we change this comment (or maybe just remove this section?), since it seems like this patch tries to avoid this path?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D111875/new/

https://reviews.llvm.org/D111875