[PATCH] D112042: [llvm-profgen] Skip duplication factor outside of body sample computation

[Wenlei He via Phabricator via llvm-commits]

wenlei added a comment.

In D112042#3075268 <https://reviews.llvm.org/D112042#3075268>, @rajeshwarv wrote:

> I'm a late to this discussion (sorry about that) but I can confirm that this shouldn't impact our production. We don't use this tool/code in our workflows but thank you for pointing it out.
>
>> The reason for this is that create_llvm_prof does not disassemble the instruction.  It just uses address range to accumulate the counters.
>
> Should we fix it in create_llvm_prof as a post-pass in the tool? I see this creates a discrepancy between our production pipeline and this power-user case (create_llvm_prof), albeit one that is benign as of today.

Actually this show the benefit of having a unified tool, so one fix in one place can take care of all users. Now llvm-profgen is almost ready for AutoFDO too (it's fully ready for CSSPGO, and FS-AutoFDO will be supported soon too), how about we all focus our effort in llvm-profgen? Would it be reasonable for you to also use llvm-profgen for internal, non-prod, power-user case?

We plan to make llvm-profgen part of production pipeline soon, replacing an internal tool, and also use it for power user case for AutoFDO, CSSPGO, and FS-AutoFDO in the future.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D112042/new/

https://reviews.llvm.org/D112042