[PATCH] D112042: [llvm-profgen] Skip duplication factor outside of body sample computation

[Rajeshwar Vanka via Phabricator via llvm-commits]

rajeshwarv added a comment.

I'm a late to this discussion (sorry about that) but I can confirm that this shouldn't impact our production. We don't use this tool/code in our workflows but thank you for pointing it out.

> The reason for this is that create_llvm_prof does not disassemble the instruction.  It just uses address range to accumulate the counters.

Should we fix it in create_llvm_prof as a post-pass in the tool? I see this creates a discrepancy between our production pipeline and this power-user case (create_llvm_prof), albeit one that is benign as of today.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D112042/new/

https://reviews.llvm.org/D112042