[PATCH] D112078: [AArch64][SVE] Add new ld<n> intrinsics that return a struct of vscale types

[Bradley Smith via Phabricator via llvm-commits]

bsmith added inline comments.


================
Comment at: llvm/lib/Target/AArch64/AArch64ISelDAGToDAG.cpp:1504
 
-  SDValue Ops[] = {N->getOperand(1), // Predicate
-                   Base,             // Memory operand
+  SDValue Ops[] = {N->getOperand(IsIntr ? 2 : 1), // Predicate
+                   Base,                          // Memory operand
----------------
CarolineConcatto wrote:
> 
> I would be tempted to check if call N->getOperand() is what is expected. 
> But I believe once we are here these checks don't need to happen anymore. Correct? 
> I am just saying this because the operand's selection is according to a newly introduced parameter that I believe is asking if this is Intrinsic.
> I believe before you had tablegen to help to check the types, but now you are using this function for other intrinsic.
I don't think checking the result of N->getOperand() is necessary, I would think that what is essentially malformed IR would have been caught by this point.

Also I'm not sure that previously we had any help from tablegen here, the existing ld<n> intrinsics already used this function.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D112078/new/

https://reviews.llvm.org/D112078