[PATCH] D112078: [AArch64][SVE] Add new ld<n> intrinsics that return a struct of vscale types

[David Sherwood via Phabricator via llvm-commits]

david-arm added inline comments.


================
Comment at: llvm/lib/Target/AArch64/AArch64ISelDAGToDAG.cpp:3904
+      } else if (VT == MVT::nxv8i16 || VT == MVT::nxv8f16 ||
+                 (VT == MVT::nxv8bf16 && Subtarget->hasBF16())) {
+        SelectPredicatedLoad(Node, 2, 1, AArch64::LD2H_IMM, AArch64::LD2H,
----------------
CarolineConcatto wrote:
> Just in case:
> When I had to work with ld3 and make tests for it.
> I needed  to change the ld to accept these types:
>     2f16, 2b16
>     4f16, 4bf16  and
>     2f32 
> Should these types be here too?
I think that's a good question! It looks like the ACLE only defines versions of the intrinsics using the fully packed types, so perhaps we never expect to see unpacked types here?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D112078/new/

https://reviews.llvm.org/D112078