[PATCH] D111288: [fir] Add data flow optimization pass

[Valentin Clement via Phabricator via llvm-commits]

clementval added a comment.

In D111288#3069727 <https://reviews.llvm.org/D111288#3069727>, @awarzynski wrote:

> Thanks for trimming the tests @clementval - now it is much clearer what is being tested! I think the the following pattern:
>
>   // CHECK-NOT:     %{{.*}} = fir.load %{{.*}} : !fir.ref<i32>
>   // CHECK:         %{{.*}} = fir.load %{{.*}} : !fir.ref<i32>
>
> can be reduced to:
>
>   // CHECK:         %{{.*}} = fir.load %{{.*}} : !fir.ref<i32>
>
> Not a blocker for me. I've also left a few inline comments, but mostly nits! LGTM (modulo the typos), but please wait for Mehdi to take a look before merging.
>
> Thanks for working on this!

Thanks for the review. I made a last pass on this patch and hopefully the last one.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D111288/new/

https://reviews.llvm.org/D111288