[PATCH] D111288: [fir] Add data flow optimization pass

[Valentin Clement via Phabricator via llvm-commits]

clementval added a comment.

In D111288#3069662 <https://reviews.llvm.org/D111288#3069662>, @kiranchandramohan wrote:

> I guess some of the arithmetic operations at various places can be removed to shorten the test. Like for e.g:
>
>   %65 = arith.subi %64, %c1 : index
>   %66 = arith.muli %5, %65 : index
>   %67 = arith.addi %66, %62 : index

Thanks for the review. I'm not sure we should trim the inputs. At least not before we have lowering tests so we make sure dialects are good together.



================
Comment at: flang/test/Fir/memref-data-flow.fir:403
+// CHECK:         %{{.*}} = fir.load %{{.*}} : !fir.ref<i32>
+// CHECL-NOT:     fir.store %{{.*}} to %{{.*}} : !fir.ref<i32>
+// CHECK:         %{{.*}} = fir.load %{{.*}} : !fir.ref<i32>
----------------
kiranchandramohan wrote:
> CHECL-NOT -> CHECK-NOT and couple of places below.
Thanks for catching this. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D111288/new/

https://reviews.llvm.org/D111288