[PATCH] D111873: [NFC][LoopVectorize] Allow getRuntimeVF to generate FP values

[Paul Walker via Phabricator via llvm-commits]

paulwalker-arm added a comment.

What about making the patch additive only.  So keep `getRuntimeVF` as is and add something like `getRuntimeVFasFloat` as the helper function?  Just a thought.  Is the patch which introduces the multiple uses big? If not then I don't see a reason for not introducing the helper function there, that way it'll be clear why you need it.



================
Comment at: llvm/lib/Transforms/Vectorize/LoopVectorize.cpp:1125
+  if (OrigTy->isFloatingPointTy())
+    Res = B.CreateSIToFP(Res, OrigTy);
+
----------------
Should this be `B.CreateUIToFP` given VF is unsigned?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D111873/new/

https://reviews.llvm.org/D111873