[PATCH] D111806: [LICM] Check the number of divergent paths from loop header to target block

Fri Oct 15 01:03:41 PDT 2021

jaykang10 added a comment.

In D111806#3065330 <https://reviews.llvm.org/D111806#3065330>, @reames wrote:

> JFYI, Roman is correct.  LICM is a canonicalizing transform.  This patch will never be accepted.  If the hoisting was not profitable, machine-licm exists precisely to undo it in a cost based way.
>
> As to your point about the profile driven piece, you are correct, that is inconsistent.  That should never have landed, or been enabled.  I'm digging through the history to figure out how that happened.

Thanks for comment @reames.

I can see you start the discussion to revert the commit with profile information.

Once the patch is reverted, let me abandon this patch.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D111806/new/

https://reviews.llvm.org/D111806