[PATCH] D111806: [LICM] Check the number of divergent paths from loop header to target block

[Philip Reames via Phabricator via llvm-commits]

reames added a comment.

JFYI, Roman is correct.  LICM is a canonicalizing transform.  This patch will never be accepted.  If the hoisting was not profitable, machine-licm exists precisely to undo it in a cost based way.

As to your point about the profile driven piece, you are correct, that is inconsistent.  That should never have landed, or been enabled.  I'm digging through the history to figure out how that happened.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D111806/new/

https://reviews.llvm.org/D111806