[PATCH] D111847: [CSSPGO] Turn off PseudoProbeUpdatePass for non-FDO builds.
Hongtao Yu via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Oct 14 17:12:18 PDT 2021
hoy updated this revision to Diff 379890.
hoy added a comment.
Fixing linter issue.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D111847/new/
https://reviews.llvm.org/D111847
Files:
llvm/lib/Passes/PassBuilderPipelines.cpp
Index: llvm/lib/Passes/PassBuilderPipelines.cpp
===================================================================
--- llvm/lib/Passes/PassBuilderPipelines.cpp
+++ llvm/lib/Passes/PassBuilderPipelines.cpp
@@ -1202,7 +1202,8 @@
// Now add the optimization pipeline.
MPM.addPass(buildModuleOptimizationPipeline(Level, LTOPreLink));
- if (PGOOpt && PGOOpt->PseudoProbeForProfiling)
+ if (PGOOpt && PGOOpt->PseudoProbeForProfiling &&
+ PGOOpt->Action == PGOOptions::SampleUse)
MPM.addPass(PseudoProbeUpdatePass());
// Emit annotation remarks.
@@ -1258,7 +1259,8 @@
// on these, we schedule the cleanup here.
MPM.addPass(createModuleToFunctionPassAdaptor(CoroCleanupPass()));
- if (PGOOpt && PGOOpt->PseudoProbeForProfiling)
+ if (PGOOpt && PGOOpt->PseudoProbeForProfiling &&
+ PGOOpt->Action == PGOOptions::SampleUse)
MPM.addPass(PseudoProbeUpdatePass());
// Handle OptimizerLastEPCallbacks added by clang on PreLink. Actual
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D111847.379890.patch
Type: text/x-patch
Size: 972 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20211015/ff4cdf93/attachment.bin>
More information about the llvm-commits
mailing list