[PATCH] D111847: [CSSPGO] Turn off PseudoProbeUpdatePass for non-FDO builds.
Hongtao Yu via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Oct 14 16:01:15 PDT 2021
hoy added inline comments.
================
Comment at: llvm/lib/Passes/PassBuilderPipelines.cpp:1261
- if (PGOOpt && PGOOpt->PseudoProbeForProfiling)
+ if (PGOOpt && PGOOpt->PseudoProbeForProfiling && PGOOpt->Action == PGOOptions::SampleUse)
MPM.addPass(PseudoProbeUpdatePass());
----------------
wenlei wrote:
> linter might complain the length of the line.
Interestingly, linter is actually fine with this. The lint build job just passed. My local linting doesn't do anything about it. I guess the linting rule has changed?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D111847/new/
https://reviews.llvm.org/D111847
More information about the llvm-commits
mailing list