[PATCH] D111386: RFC: [Hexagon] Mark target as not "machine verifier clean"

Matthias Braun via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Oct 14 10:19:18 PDT 2021


MatzeB added a comment.

> One problem that came up is that the "BB Sections" pass runs before pre-emit2. This imposes restrictions on what kinds of optimizations we can run in pre-emit2. If we could move BB Sections until after pre-emit2, it would be a lot better for us.

I see, thanks for trying things out! The problem with moving "BB Sections" after `addPreEmit2` is that again we are moving passes behind the supposedly last thing before emission. That is what happened to `addPreEmit` which prompted the addition of `addPreEmit2` (and its silly name). For that reason I'd rather not start adding passes behind `addPreEmit2` for now.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D111386/new/

https://reviews.llvm.org/D111386



More information about the llvm-commits mailing list