[PATCH] D111403: [Inliner] Don't inline functions with incompatible vscale_range attributes

[Cullen Rhodes via Phabricator via llvm-commits]

c-rhodes abandoned this revision.
c-rhodes added a comment.

In D111403#3063588 <https://reviews.llvm.org/D111403#3063588>, @paulwalker-arm wrote:

> Hi @c-rhodes , sorry for not getting to this until after you've spent time fixing up review comments but I'm struggling to see what bug this patch is trying to fix and how preventing function inlining fixes it.  From what I can see we're basically saying that when function A calls function B and function A's vscale_range is incompatible with function B's then we should not allow B to be inlined into A.  But if the two functions have incompatible vscale_range attributes then the actual bug is that A should not be calling B (i.e. it's a bug in user code) and preventing inline will not fix that.  What do you think? Have I misunderstood something?

Thanks for raising this Paul, it seems you're right this isn't actually necessary. It was thought this type of inlining with incompatible vscale_range attributes could occur when using function multi-versioning, but that seems unlikely.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D111403/new/

https://reviews.llvm.org/D111403