[PATCH] D111551: [AArch64] Split out processor/tuning features

Thu Oct 14 05:23:19 PDT 2021

dmgreen requested changes to this revision.
dmgreen added a comment.
This revision now requires changes to proceed.

In D111551#3063765 <https://reviews.llvm.org/D111551#3063765>, @sdesmalen wrote:

> LGTM, thanks for the changes!
>
> I'm not sure how you could easily write tests for this, other than creating a TableGen tool to generate the list of features per CPU, and comparing it with a predefined list of features. But that requires quite a bit of work to make it into an LLVM tool and create a lit test and tbh I'm not sure how valuable such tests would be. I have confirmed your test is NFC, so I'm happy for this patch to move forward.

There does need to be some tests. Can there not be tests that show that -target-cpu does one thing and -tune-cpu does another? They only need to be .ll tests, and I'm not talking about testing every feature, but there needs to be something.

================
Comment at: llvm/lib/Target/AArch64/AArch64.td:985
+
+def : ProcessorModel<"generic", CortexA55Model, ProcessorFeatures.Generic, [FeatureFuseAES, FeaturePostRAScheduler]>;
+def : ProcessorModel<"cortex-a35", CortexA53Model, ProcessorFeatures.A53, [TuneA35]>;
----------------
All these lines are still too long and need to cleaned up.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D111551/new/

https://reviews.llvm.org/D111551