[PATCH] D111551: [AArch64] Split out processor/tuning features
Sander de Smalen via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Oct 14 05:18:35 PDT 2021
sdesmalen accepted this revision.
sdesmalen added a comment.
This revision is now accepted and ready to land.
LGTM, thanks for the changes!
I'm not sure how you could easily write tests for this, other than creating a TableGen tool to generate the list of features per CPU, and comparing it with a predefined list of features. But that requires quite a bit of work to make it into an LLVM tool and create a lit test and tbh I'm not sure how valuable such tests would be. I have confirmed your test is NFC, so I'm happy for this patch to move forward.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D111551/new/
https://reviews.llvm.org/D111551
More information about the llvm-commits
mailing list