[PATCH] D111162: [UnknownProvenance] Add llvm-c support

[Jeroen Dobbelaere via Phabricator via llvm-commits]

jeroen.dobbelaere added inline comments.


================
Comment at: llvm/tools/llvm-c-test/echo.cpp:354
+    return LLVMGetUnknownProvenance(TypeCloner(M).Clone(Cst));
+  }
+
----------------
deadalnix wrote:
> This is great that you though of updating the echo test.
> 
> The echo test is a test that read some IR, and then spit it back out, using the C API. There are some files containing LLVM IR that contain various pieces of IR that are run through he echo tool. This ensure that the IR is read and then regenerated properly through the C API.
> 
> It would be great if you could either modify an existing test or add a new one so that the unknown provenance construct is exercised by the C API - which in turn will prove that this code works as expected.
Could you point me to a test that is using this 'echo' ? It is possible that I can only add the test itself once D104268, D104269 and D104270 are added.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D111162/new/

https://reviews.llvm.org/D111162