[PATCH] D111162: [UnknownProvenance] Add llvm-c support

[Amaury SECHET via Phabricator via llvm-commits]

deadalnix requested changes to this revision.
deadalnix added inline comments.
This revision now requires changes to proceed.


================
Comment at: llvm/tools/llvm-c-test/echo.cpp:354
+    return LLVMGetUnknownProvenance(TypeCloner(M).Clone(Cst));
+  }
+
----------------
This is great that you though of updating the echo test.

The echo test is a test that read some IR, and then spit it back out, using the C API. There are some files containing LLVM IR that contain various pieces of IR that are run through he echo tool. This ensure that the IR is read and then regenerated properly through the C API.

It would be great if you could either modify an existing test or add a new one so that the unknown provenance construct is exercised by the C API - which in turn will prove that this code works as expected.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D111162/new/

https://reviews.llvm.org/D111162