[PATCH] D111034: [AArch64] Optimize add/sub with immediate
Ben Shi via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Oct 12 07:50:54 PDT 2021
benshi001 marked an inline comment as done.
benshi001 added inline comments.
================
Comment at: llvm/lib/Target/AArch64/AArch64MIPeepholeOpt.cpp:146
// of UImm to zero.
if (SubregToRegMI)
UImm &= 0xFFFFFFFF;
----------------
dmgreen wrote:
> Do we need the equivalent of this in the new code? Or i s it Ok because of the 0xffffff check at the start of splitAddSubImm?
I do not think we need such operation, since the check in splitAddSubImm has guarenteed that.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D111034/new/
https://reviews.llvm.org/D111034
More information about the llvm-commits
mailing list