[PATCH] D111034: [AArch64] Optimize add/sub with immediate

[Dave Green via Phabricator via llvm-commits]

dmgreen added a comment.

Thanks. Code looks good to me.

Are there test cases anywhere for having these adds in a loop? And for negative tests where we are out of range for the transform?



================
Comment at: llvm/lib/Target/AArch64/AArch64MIPeepholeOpt.cpp:146
   // of UImm to zero.
   if (SubregToRegMI)
     UImm &= 0xFFFFFFFF;
----------------
Do we need the equivalent of this in the new code? Or i s it Ok because of the 0xffffff check at the start of splitAddSubImm?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D111034/new/

https://reviews.llvm.org/D111034