[PATCH] D111241: [APInt] Fix isAllOnes and extractBits for zero width values.

Jay Foad via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Oct 12 07:32:51 PDT 2021


foad added a comment.

In D111241#3058363 <https://reviews.llvm.org/D111241#3058363>, @joerg wrote:

> Did this get an audit for existing users? It can be argued in both ways. E.g. `"".isdigit()` in Python is False, because there is no digit contained and that's pretty much the same use case.

AFAIK there are no in-tree users to audit: zero-width APInts were only introduced very recently, and I don't think they're used in-tree except for unit tests.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D111241/new/

https://reviews.llvm.org/D111241



More information about the llvm-commits mailing list