[PATCH] D111525: [fir] Update clang-tidy for the Optimizer directory

[Valentin Clement via Phabricator via llvm-commits]

clementval added a comment.

In D111525#3056893 <https://reviews.llvm.org/D111525#3056893>, @mehdi_amini wrote:

> In D111525#3056452 <https://reviews.llvm.org/D111525#3056452>, @schweitz wrote:
>
>> In D111525#3055658 <https://reviews.llvm.org/D111525#3055658>, @mehdi_amini wrote:
>>
>>> I'm a bit puzzled, many of the values are already defined at the top-level and I don't see an override on the path there. What's the effect of this?
>>>
>>> Please provide correct commit description, just saying `Update .clang-tidy file with the value used in fir-dev.` isn't helpful.
>>
>> Actually, they aren't.  flang/.clang-tidy has a number of deltas to {mlir,llvm}/.clang-tidy,
>
> I looked before commenting, I didn't spot it, can you link more precisely?
>
> For example here is what I see at HEAD:
>
>   $ cat flang/.clang-tidy 
>   Checks: '-llvm-include-order,readability-braces-around-statements,-readability-identifier-naming,-clang-diagnostic-*'
>   InheritParentConfig: true
>
> And at the top level the values are matching what is added in this revision.

I guess you mean `llvm-project/.clang-tidy` if so you are right the key/value are the same. If this is a problem to ensure those value at this level we can probably remove them. For the commit message I'm not sure we can be more helpful. The changes are self-explanatory so it would help much to describe it in the commit message in my opinion.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D111525/new/

https://reviews.llvm.org/D111525