[PATCH] D111525: [fir] Update clang-tidy for the Optimizer directory

Mehdi AMINI via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Oct 11 19:27:20 PDT 2021


mehdi_amini added a comment.

In D111525#3056452 <https://reviews.llvm.org/D111525#3056452>, @schweitz wrote:

> In D111525#3055658 <https://reviews.llvm.org/D111525#3055658>, @mehdi_amini wrote:
>
>> I'm a bit puzzled, many of the values are already defined at the top-level and I don't see an override on the path there. What's the effect of this?
>>
>> Please provide correct commit description, just saying `Update .clang-tidy file with the value used in fir-dev.` isn't helpful.
>
> Actually, they aren't.  flang/.clang-tidy has a number of deltas to {mlir,llvm}/.clang-tidy,

I looked before commenting, I didn't spot it, can you link more precisely?

For example here is what I see at HEAD:

  $ cat flang/.clang-tidy 
  Checks: '-llvm-include-order,readability-braces-around-statements,-readability-identifier-naming,-clang-diagnostic-*'
  InheritParentConfig: true

And at the top level the values are matching what is added in this revision.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D111525/new/

https://reviews.llvm.org/D111525



More information about the llvm-commits mailing list