[PATCH] D111539: [fir] Clean up InitFIR.h

[Valentin Clement via Phabricator via llvm-commits]

clementval added inline comments.


================
Comment at: flang/include/flang/Optimizer/Support/InitFIR.h:30
       mlir::omp::OpenMPDialect, mlir::scf::SCFDialect,                         \
       mlir::StandardOpsDialect, mlir::vector::VectorDialect
 
----------------
mehdi_amini wrote:
> clementval wrote:
> > mehdi_amini wrote:
> > > This macro is unused? If so can you just remove it?
> > It is used on line 34. 
> Uh, I missed this somehow (I probably fat-fingered when I did cmd+f to search on the page).
> 
> How is this macro intended to be used otherwise? (i.e. there must be a reason to split it right?)
> Likely worth a comment.
It will be used when we can upstream more code here (which we cannot at the moment since it will bring 10'000 lines with it).

The two functions below will be used by the new flang driver

```
inline void registerNonCodegenDialects(mlir::DialectRegistry &registry) {
  registry.insert<FLANG_NONCODEGEN_DIALECT_LIST>();
}

inline void registerDialects(mlir::DialectRegistry &registry) {
  registry.insert<FLANG_DIALECT_LIST>();
}
```


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D111539/new/

https://reviews.llvm.org/D111539