[PATCH] D111539: [fir] Clean up InitFIR.h

[Mehdi AMINI via Phabricator via llvm-commits]

mehdi_amini added inline comments.


================
Comment at: flang/include/flang/Optimizer/Support/InitFIR.h:30
       mlir::omp::OpenMPDialect, mlir::scf::SCFDialect,                         \
       mlir::StandardOpsDialect, mlir::vector::VectorDialect
 
----------------
clementval wrote:
> mehdi_amini wrote:
> > This macro is unused? If so can you just remove it?
> It is used on line 34. 
Uh, I missed this somehow (I probably fat-fingered when I did cmd+f to search on the page).

How is this macro intended to be used otherwise? (i.e. there must be a reason to split it right?)
Likely worth a comment.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D111539/new/

https://reviews.llvm.org/D111539