[PATCH] D111502: [TableGen] Fix both sides of '&&' are same

Simon Pilgrim via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Oct 10 09:03:47 PDT 2021


RKSimon added inline comments.


================
Comment at: llvm/utils/TableGen/CodeGenDAGPatterns.h:301
   /// Make sure that for each type in \p Small, there exists a larger type
   /// in \p Big.
+  bool EnforceSmallerThan(TypeSetByHwMode &Small, TypeSetByHwMode &Big,
----------------
Comments? A magic hack like this needs the explanation as clear as possible and not just mentioned in the cpp implementation.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D111502/new/

https://reviews.llvm.org/D111502



More information about the llvm-commits mailing list