[PATCH] D111410: [InstCombine] generalize fold for mask-with-signbit-splat
Sanjay Patel via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Oct 8 10:42:08 PDT 2021
spatel added a comment.
In D111410#3051834 <https://reviews.llvm.org/D111410#3051834>, @RKSimon wrote:
> LGTM
>
>> So I think this patch makes things more consistent. But if the more specific transform was here as a work-around, we could leave it in as a special-case before we do the more general fold (...but that would be pretty hacky).
>
> Maybe remove the current fold as a followup commit to make bisection a little easier if somebody was depending upon it?
Yes - that will make it clearer. Also, I found the existing 'or' sibling to this was added with D67800 <https://reviews.llvm.org/D67800>, so I'll do the same sequence with that one.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D111410/new/
https://reviews.llvm.org/D111410
More information about the llvm-commits
mailing list